Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDS-34265-skip-label-selector-tracking-for-k8s-deployments #809

Merged
merged 3 commits into from
Mar 8, 2023
Merged

CDS-34265-skip-label-selector-tracking-for-k8s-deployments #809

merged 3 commits into from
Mar 8, 2023

Conversation

roshnisarangadharan
Copy link
Contributor

Added a new topic to the K8s deployment section under CD-Advanced

Harness Developer Pull Request

Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.

What Type of PR is This?

  • Issue
  • Feature
  • Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

  • Issue(s)

House Keeping

Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

  • Tested Locally
  • Optional Screen Shoot.

@roshnisarangadharan
CDS-34265-skip-label-selector-tracking-for-k8s-deployments
9f740f1 
Added a new topic to the K8s deployment section under CD-Advanced
@roshnisarangadharan roshnisarangadharan added Review - SME Needs tech review from SME/dev/eng DO NOT MERGE PR is not ready to be merged. labels Feb 24, 2023
@roshnisarangadharan roshnisarangadharan self-assigned this Feb 24, 2023
abosii-harness
abosii-harness previously approved these changes Mar 7, 2023
View reviewed changes
@roshnisarangadharan roshnisarangadharan added peer review and removed Review - SME Needs tech review from SME/dev/eng labels Mar 7, 2023
SmritiSatya
SmritiSatya previously approved these changes Mar 7, 2023
View reviewed changes
@bot-gitexp-user
Copy link

Preview environment: https://hdh.pr.harness.io/pr-809

SmritiSatya
SmritiSatya previously approved these changes Mar 7, 2023
View reviewed changes
michaelcretzman
michaelcretzman previously approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@michaelcretzman michaelcretzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving with the assumption that you will consider my suggestions.

@roshnisarangadharan @michaelcretzman
Apply suggestions from code review
7d7aaa4 
Co-authored-by: Michael Cretzman <58786311+michaelcretzman@users.noreply.github.com>
@bot-gitexp-user
Copy link

Preview environment: https://hdh.pr.harness.io/pr-809

@roshnisarangadharan roshnisarangadharan merged commit d0274f6 into main Mar 8, 2023
@roshnisarangadharan roshnisarangadharan deleted the CDS-34265-skip-harness-label-selector branch March 8, 2023 06:20
@roshnisarangadharan roshnisarangadharan restored the CDS-34265-skip-harness-label-selector branch March 8, 2023 06:20
@ravilach ravilach deleted the CDS-34265-skip-harness-label-selector branch March 30, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charanya-j charanya-j charanya-j approved these changes

@michaelcretzman michaelcretzman michaelcretzman left review comments

@abosii-harness abosii-harness abosii-harness left review comments

@SmritiSatya SmritiSatya SmritiSatya left review comments

Assignees

@roshnisarangadharan roshnisarangadharan

Labels
DO NOT MERGE PR is not ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@roshnisarangadharan @bot-gitexp-user @michaelcretzman @abosii-harness @charanya-j @SmritiSatya