Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDS-52164-Custom Webhook Trigger for Non-Harness CI System #730

Conversation

roshnisarangadharan
Copy link
Contributor

Added a use case for triggering a pipeline from a thrid-party CI system using custom webhook trigger

Harness Developer Pull Request

Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.

What Type of PR is This?

  • Issue
  • Feature
  • Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

  • Issue(s)

House Keeping

Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

  • Tested Locally
  • Optional Screen Shoot.

Added a use case for triggering a pipeline from a thrid-party CI system using custom webhook trigger
@roshnisarangadharan roshnisarangadharan self-assigned this Feb 16, 2023
@roshnisarangadharan roshnisarangadharan added Review - SME Needs tech review from SME/dev/eng DO NOT MERGE PR is not ready to be merged. labels Feb 16, 2023
@roshnisarangadharan roshnisarangadharan changed the title CDS-52164 CDS-52164-Custom Webhook Trigger for Non-Harness CI System Feb 16, 2023
@roshnisarangadharan
Copy link
Contributor Author

unsuccessful pipeline check

minor text edits
@bot-gitexp-user
Copy link

Preview environment: https://ci.pr.harness.io/pr-730

thisrohangupta
thisrohangupta previously approved these changes Feb 27, 2023
Copy link
Collaborator

@thisrohangupta thisrohangupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good thank you!

@roshnisarangadharan roshnisarangadharan added peer review and removed Review - SME Needs tech review from SME/dev/eng labels Feb 28, 2023
@bot-gitexp-user
Copy link

Preview environment: https://hdh.pr.harness.io/pr-730

@bot-gitexp-user
Copy link

Preview environment: https://hdh.pr.harness.io/pr-730

michaelcretzman
michaelcretzman previously approved these changes Mar 1, 2023
Copy link
Contributor

@michaelcretzman michaelcretzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving with the assumption that you will consider my suggestions.

Co-authored-by: Michael Cretzman <58786311+michaelcretzman@users.noreply.github.com>
KimberlyFields
KimberlyFields previously approved these changes Mar 6, 2023
Copy link
Contributor

@KimberlyFields KimberlyFields left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with one suggestion.

…-ci-system.md

Co-authored-by: KimberlyFields <46325568+KimberlyFields@users.noreply.github.com>
@bot-gitexp-user
Copy link

Preview environment: https://hdh.pr.harness.io/pr-730

@roshnisarangadharan roshnisarangadharan merged commit ec10d82 into main Mar 7, 2023
@roshnisarangadharan roshnisarangadharan deleted the CDS-52164-custom-webhook-trigger-for-non-harness-pipeline branch March 7, 2023 07:46
@roshnisarangadharan roshnisarangadharan restored the CDS-52164-custom-webhook-trigger-for-non-harness-pipeline branch March 7, 2023 07:47
@ravilach ravilach deleted the CDS-52164-custom-webhook-trigger-for-non-harness-pipeline branch March 30, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE PR is not ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants