Skip to content

Conversation

hrprz-overops
Copy link
Contributor

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.

Description

  • Please describe your changes: __________________________________
  • Jira/GitHub Issue numbers (if any): ______________________________
  • Preview links/images (Internal contributors only): __________________

PR lifecycle

We aim to merge PRs within one week or less, but delays happen sometimes.

If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.

PRs must meet these requirements to be merged:

  • Successful preview build.
  • Code owner review.
  • No merge conflicts.
  • Release notes/new features docs: Feature/version released to at least one prod environment.

@CLAassistant
Copy link

CLAassistant commented Jun 18, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ saifeemustafaqharness
❌ hrprz-overops
You have signed the CLA already but the status is still pending? Let us recheck it.

@brian-r-fisher brian-r-fisher added DO NOT MERGE PR is not ready to be merged. Review - Editorial Needs style/editorial review from docs council labels Jun 19, 2024
@saifeemustafaqharness
Copy link
Contributor

The build has been failing repeatedly.

I have tried adding code ticks to ignore the variable and consider it as code snippets.

Cause: Unexpected character + (U+002B) before name, expected a character that can start a name, such as a letter, $, or _
Details:
{
"column": 15,
"message": "Unexpected character + (U+002B) before name, expected a character that can start a name, such as a letter, $, or _",
"line": 3314,
"name": "3314:15",
"place": {
"line": 3314,
"column": 15,
"offset": 218056,
"_index": 0,
"_bufferIndex": 14
},
"reason": "Unexpected character + (U+002B) before name, expected a character that can start a name, such as a letter, $, or _",
"ruleId": "unexpected-character",
"source": "micromark-extension-mdx-jsx",
"url": "https://github.com/micromark/micromark-extension-mdx-jsx#unexpected-character-at-expected-expect"
}

Copy link

@brian-r-fisher brian-r-fisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saifeemustafaqharness If you commit these suggestions, the build should be successful.

Comment on lines +3314 to +3317
For example: `<+pipeline.variables.get("this-var")>`



Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For example: `<+pipeline.variables.get("this-var")>`
For example: `<+pipeline.variables.get("this-var")>`

Co-authored-by: brian-f <brian.fisher@harness.io>
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://667961f9cf35c4b16398f4ae--harness-developer.netlify.app

@brian-r-fisher
Copy link

@saifeemustafaqharness The build is fixed now. After you make any necessary copy edits and move the questions to the applicable categories, I'll re-review and then you can merge the PR.

@bot2-harness
Copy link

This pull request has been automatically closed due to 30 days of inactivity. If you believe this was done in error, please feel free to reopen the PR or reach out to the BT team for further assistance. Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE PR is not ready to be merged. Review - Editorial Needs style/editorial review from docs council
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants