Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ci grab bag 23 apr 24 #6426

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Ci grab bag 23 apr 24 #6426

merged 2 commits into from
Apr 23, 2024

Conversation

aimurphy
Copy link
Contributor

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.

Description

  • Please describe your changes: Hide an unreleased FF. Add permissions for secure connect API key.
  • Jira/GitHub Issue numbers (if any): CI-12133
  • Preview links/images (Internal contributors only): building

PR lifecycle

We aim to merge PRs within one week or less, but delays happen sometimes.

If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.

PRs must meet these requirements to be merged:

  • Successful preview build.
  • Code owner review.
  • No merge conflicts.
  • Release notes/new features docs: Feature/version released to at least one prod environment.

@aimurphy aimurphy added Content - chore/cleanup Content flag: Cleanup or edits on previously published content Review - Editorial Needs style/editorial review from docs council Content - gap / tech debt Content flag: This PR includes missing content or docs tech debt labels Apr 23, 2024
@aimurphy aimurphy self-assigned this Apr 23, 2024
jenniferopal
jenniferopal approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@jenniferopal jenniferopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6627dbb81662c20fddb9aad0--harness-developer.netlify.app

@aimurphy aimurphy merged commit 11302a1 into main Apr 23, 2024
2 checks passed
@aimurphy aimurphy deleted the ci-grab-bag-23-apr-24 branch April 23, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenniferopal jenniferopal jenniferopal approved these changes

Assignees

@aimurphy aimurphy

Labels
Content - chore/cleanup Content flag: Cleanup or edits on previously published content Content - gap / tech debt Content flag: This PR includes missing content or docs tech debt Review - Editorial Needs style/editorial review from docs council
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aimurphy @bot-gitexp-user @jenniferopal