Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New topic Update STO Images STO-7078 #5235

Closed
wants to merge 9 commits into from
Closed

New topic Update STO Images STO-7078 #5235

wants to merge 9 commits into from

Conversation

douglas-j-bothwell
Copy link
Contributor

@douglas-j-bothwell douglas-j-bothwell commented Feb 1, 2024 •
edited
Loading

@douglas-j-bothwell douglas-j-bothwell self-assigned this Feb 1, 2024
@douglas-j-bothwell douglas-j-bothwell added the DO NOT MERGE PR is not ready to be merged. label Feb 1, 2024
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65bbe6cd40b0d7161ba052c8--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65bc386209fcd01214bb3ed8--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65bc3b9d3ab67a15f82485e0--harness-developer.netlify.app

@douglas-j-bothwell douglas-j-bothwell added Review - SME Needs tech review from SME/dev/eng Review - PM Needs review from PM labels Feb 2, 2024
@douglas-j-bothwell douglas-j-bothwell changed the title v0 STO Images topic STO-7078 New topic Update STO Images STO-7078 Feb 3, 2024
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65be909533787dc696ef3260--harness-developer.netlify.app

aimurphy
aimurphy reviewed Feb 5, 2024
View reviewed changes
Copy link
Contributor

@aimurphy aimurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add redirects for moved topics and renamed category page, otherwise LGTM. Some optional suggestions otherwise.

aimurphy
aimurphy reviewed Feb 5, 2024
View reviewed changes
_server-redirects
@@ -28,3 +28,5 @@

# Redirects generated from Front Matter [sytem generated goes below here]:

# Added by douglas-j-bothwell on Feb-5-2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this above line 29.

@douglas-j-bothwell
Copy link
Contributor Author

Closing this ticket, I've implemented the changes in a new PR: #5272

@ravilach ravilach deleted the updating-sto-images-sto-7078 branch May 6, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aimurphy aimurphy aimurphy left review comments

@brian-r-fisher brian-r-fisher Awaiting requested review from brian-r-fisher

@harishkammanahalli harishkammanahalli Awaiting requested review from harishkammanahalli

@ravilach ravilach Awaiting requested review from ravilach

@wei-harness wei-harness Awaiting requested review from wei-harness wei-harness is a code owner

Assignees

@douglas-j-bothwell douglas-j-bothwell

Labels
DO NOT MERGE PR is not ready to be merged. Review - PM Needs review from PM Review - SME Needs tech review from SME/dev/eng
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@douglas-j-bothwell @bot-gitexp-user @aimurphy