Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CD 804xx relnotes CDS-7758 #3036

Merged
merged 8 commits into from
Sep 5, 2023
Merged

CD 804xx relnotes CDS-7758 #3036

merged 8 commits into from
Sep 5, 2023

Conversation

douglas-j-bothwell
Copy link
Contributor

@douglas-j-bothwell douglas-j-bothwell commented Aug 25, 2023 •
edited
Loading

Harness Developer Pull Request

If tied to an Issue, list the Issue(s) here:

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

deepakbolangady
deepakbolangady previously approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@deepakbolangady deepakbolangady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with some comments/questions.

@douglas-j-bothwell
Apply suggestions from code review
7582508 
DB peer-review edits

Co-authored-by: Deepak Bolangady <deepak.bolangady@harness.io>
@douglas-j-bothwell
Apply suggestions from code review
89588cf 
more DB peer-review edits

Co-authored-by: Deepak Bolangady <deepak.bolangady@harness.io>
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

1 similar comment
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@douglas-j-bothwell douglas-j-bothwell added Review - PM Needs review from PM DO NOT MERGE PR is not ready to be merged. labels Aug 29, 2023
@douglas-j-bothwell douglas-j-bothwell removed the Review - PM Needs review from PM label Aug 29, 2023
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@deepakbolangady deepakbolangady merged commit 8279f68 into main Sep 5, 2023
@deepakbolangady deepakbolangady deleted the cd-relnotes-804xx-cds-7758 branch September 5, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepakbolangady deepakbolangady deepakbolangady approved these changes

@prasadsatamharness prasadsatamharness prasadsatamharness left review comments

Assignees

@douglas-j-bothwell douglas-j-bothwell

Labels
DO NOT MERGE PR is not ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@douglas-j-bothwell @bot-gitexp-user @deepakbolangady @prasadsatamharness