Skip to content

CDS-54294-HPA and PDB support for K8s Blue Green and Canary deployments #2047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 9, 2023
Merged

CDS-54294-HPA and PDB support for K8s Blue Green and Canary deployments #2047

merged 11 commits into from
Jun 9, 2023

Conversation

roshnisarangadharan
Copy link
Contributor

Harness Developer Pull Request

Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.

What Type of PR is This?

  • Issue
  • Feature
  • Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

  • Issue(s)

House Keeping

Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

  • Tested Locally
  • Optional Screen Shoot.

@roshnisarangadharan roshnisarangadharan added documentation Review - SME Needs tech review from SME/dev/eng DO NOT MERGE PR is not ready to be merged. labels Jun 8, 2023
@roshnisarangadharan roshnisarangadharan self-assigned this Jun 8, 2023
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

markoharness
markoharness previously approved these changes Jun 9, 2023
View reviewed changes
markoharness
markoharness previously approved these changes Jun 9, 2023
View reviewed changes
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

3 similar comments
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@roshnisarangadharan
Copy link
Contributor Author

Preview links:
BG HPA: https://6482db72d2034335cf25de00--harness-developer.netlify.app/docs/continuous-delivery/deploy-srv-diff-platforms/kubernetes/kubernetes-executions/create-a-kubernetes-blue-green-deployment#using-horizontal-pod-autoscaler-hpa
BG PDB: https://6482db72d2034335cf25de00--harness-developer.netlify.app/docs/continuous-delivery/deploy-srv-diff-platforms/kubernetes/kubernetes-executions/create-a-kubernetes-blue-green-deployment#using-pod-disruption-budget-pdb
Canary HPA: https://6482db72d2034335cf25de00--harness-developer.netlify.app/docs/continuous-delivery/deploy-srv-diff-platforms/kubernetes/kubernetes-executions/create-a-kubernetes-canary-deployment#using-horizontal-pod-autoscaler-hpa
Canary PDB: https://6482db72d2034335cf25de00--harness-developer.netlify.app/docs/continuous-delivery/deploy-srv-diff-platforms/kubernetes/kubernetes-executions/create-a-kubernetes-canary-deployment#using-pod-disruption-budget-pdb
Managed workload table: https://6482db72d2034335cf25de00--harness-developer.netlify.app/docs/continuous-delivery/deploy-srv-diff-platforms/kubernetes/cd-k8s-ref/what-can-i-deploy-in-kubernetes#managed-workloads-table

rashminandasahoo
rashminandasahoo previously approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@rashminandasahoo rashminandasahoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor suggestions. Nice work!

@roshnisarangadharan @rashminandasahoo
Apply suggestions from code review
89a7826 
Co-authored-by: rashminandasahoo <82015227+rashminandasahoo@users.noreply.github.com>
@roshnisarangadharan
Update docs/continuous-delivery/deploy-srv-diff-platforms/kubernetes/…
6d97ef5 
…kubernetes-executions/create-a-kubernetes-canary-deployment.md
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

2 similar comments
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@roshnisarangadharan roshnisarangadharan merged commit e4cb378 into main Jun 9, 2023
@roshnisarangadharan roshnisarangadharan deleted the CDS-56294-HPA-PDP-support branch June 9, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acasian-harness acasian-harness Awaiting requested review from acasian-harness

2 more reviewers

@rashminandasahoo rashminandasahoo rashminandasahoo left review comments

@markoharness markoharness markoharness left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@roshnisarangadharan roshnisarangadharan

Labels
DO NOT MERGE PR is not ready to be merged. Review - SME Needs tech review from SME/dev/eng
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roshnisarangadharan @bot-gitexp-user @rashminandasahoo @markoharness