Skip to content

Conversation

brian-r-fisher
Copy link

@brian-r-fisher brian-r-fisher commented Jun 5, 2023

Add AWS Connector EKS IRSA Delegate Setup details

For reviewers, a preview is available:

AWS connector settings reference

What Type of PR is This?

  • Issue
  • Feature
  • Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

  • Issue(s)

House Keeping

Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

  • Tested Locally
  • Optional Screen Shoot.

@brian-r-fisher brian-r-fisher added the Review - SME Needs tech review from SME/dev/eng label Jun 5, 2023
@brian-r-fisher brian-r-fisher self-assigned this Jun 5, 2023
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

1 similar comment
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@brian-r-fisher brian-r-fisher requested a review from pratmit June 15, 2023 22:57
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

1 similar comment
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@brian-r-fisher brian-r-fisher requested review from sainath-b and manish-manchanda and removed request for pratmit June 21, 2023 02:35
@brian-r-fisher brian-r-fisher added the DO NOT MERGE PR is not ready to be merged. label Jul 6, 2023
@brian-r-fisher brian-r-fisher requested review from xingchi-jin and removed request for sainath-b and manish-manchanda July 10, 2023 13:58
@brian-r-fisher brian-r-fisher added peer review and removed Review - SME Needs tech review from SME/dev/eng labels Aug 2, 2023
---
apiVersion: apps/v1
kind: StatefulSet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this is legacy delegate yaml ? I think now it'd be immutable in our documents

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xingchi-jin Can you help with immutable image type delegate yaml?

@brian-r-fisher brian-r-fisher added Review - SME Needs tech review from SME/dev/eng and removed peer review labels Aug 2, 2023
@ravilach
Copy link
Collaborator

@brian-f-harness do you still need this? Was flagged by GH as stale. -Ravi

@brian-r-fisher
Copy link
Author

@brian-f-harness do you still need this? Was flagged by GH as stale. -Ravi

@ravilach Yes, I'm working with eng to correct the sample file. I will merge main and fix the conflict.

@brian-r-fisher
Copy link
Author

Closing in favor of PR #3442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE PR is not ready to be merged. Review - SME Needs tech review from SME/dev/eng
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants