Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pl 38504 multiple idp #1738

Merged
merged 10 commits into from
May 26, 2023
Merged

Pl 38504 multiple idp #1738

merged 10 commits into from
May 26, 2023

Conversation

rashminandasahoo
Copy link
Contributor

@rashminandasahoo rashminandasahoo commented May 16, 2023

New topic on configuring multiple SAML providers

What Type of PR is This?

  • Issue
  • [ x] Feature
  • Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

  • Issue(s)

House Keeping

Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

  • [ x] Tested Locally
  • [x ] Optional Screen Shoot.
multiple-idp-list-saml

Preview link: https://646369453e92b000aa35bd21--harness-developer.netlify.app/

@rashminandasahoo rashminandasahoo added the Draft Draft/work-in-progress label May 16, 2023
@rashminandasahoo rashminandasahoo self-assigned this May 16, 2023
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

pbarapatre10
pbarapatre10 previously approved these changes May 19, 2023
Copy link
Contributor

@deepakbolangady deepakbolangady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I requested Engineering for access to an account with this UI, but I was not able to complete my testing. I cannot tell at this time whether you and I saw the same UI, but I'll check once more as soon as I can.

For now, I'll approve assuming that you'll make the changes. If you have questions, please ask. Thanks.

@@ -0,0 +1,87 @@
---
title: Multiple Identity Providers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use sentence case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

If you already have a configured SAML provider, select **Add SAML Provider** to add another SAML provider.
The SAML Provider settings appear.
3. In **Name**, enter a name for the SAML provider.
4. Enter a name in **Friendly Name** if you want this to be displayed in the login screen.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not see the friendly name field, and I cannot learn why at this time. I'm sure it was there when you saw it, so that's okay. But it'll be good if you can take another look too. Thanks.

Either way, specify the goal first: if you want a friendly name to be displayed on the login screen, enter the name in Friendly Name.
(Remember: a screen is a 2D object for the purposes of our documentation, so the right preposition is "on".)


2. Select **Continue**.
3. Select **Submit**.
The SAML provider is now listed in **Login via SAML**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should inform the UI development team that the name of the UI element should be "Log in via SAML". Can you create a Jira ticket for them?

rashminandasahoo and others added 6 commits May 21, 2023 13:07
Co-authored-by: Deepak Bolangady <deepak.bolangady@harness.io>
Co-authored-by: Deepak Bolangady <deepak.bolangady@harness.io>
Co-authored-by: Deepak Bolangady <deepak.bolangady@harness.io>
Co-authored-by: Deepak Bolangady <deepak.bolangady@harness.io>
Co-authored-by: Deepak Bolangady <deepak.bolangady@harness.io>
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

6 similar comments
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@rashminandasahoo rashminandasahoo merged commit 00cf5ed into main May 26, 2023
@rashminandasahoo rashminandasahoo deleted the PL-38504-multiple-IDP branch May 26, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Draft Draft/work-in-progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants