Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CDS-51341] Filter support for templates #1595

Merged
merged 10 commits into from
May 4, 2023
Merged

[CDS-51341] Filter support for templates #1595

merged 10 commits into from
May 4, 2023

Conversation

rashminandasahoo
Copy link
Contributor

Harness Developer Pull Request

Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.

What Type of PR is This?

  • Issue
  • Feature
  • Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

  • Issue(s)

House Keeping

Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

  • Tested Locally
  • Optional Screen Shoot.

@rashminandasahoo rashminandasahoo added the Draft Draft/work-in-progress label May 4, 2023
@rashminandasahoo rashminandasahoo self-assigned this May 4, 2023
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

StrawberryPad
StrawberryPad suggested changes May 4, 2023
View reviewed changes
Copy link
Contributor

@StrawberryPad StrawberryPad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are mostly "should do" to improve usability. There's only one typo (missing an "a" in a sentence).

rashminandasahoo and others added 8 commits May 4, 2023 14:31
@rashminandasahoo @StrawberryPad
Update docs/platform/13_Templates/template.md
7c49c62 
Co-authored-by: Gigi Hanna <126673019+StrawberryPad@users.noreply.github.com>
@rashminandasahoo @StrawberryPad
Update docs/platform/13_Templates/template.md
61114a5 
Co-authored-by: Gigi Hanna <126673019+StrawberryPad@users.noreply.github.com>
@rashminandasahoo @StrawberryPad
Update docs/platform/13_Templates/template.md
6609854 
Co-authored-by: Gigi Hanna <126673019+StrawberryPad@users.noreply.github.com>
@rashminandasahoo @StrawberryPad
Update docs/platform/13_Templates/template.md
bbc2b8a 
Co-authored-by: Gigi Hanna <126673019+StrawberryPad@users.noreply.github.com>
@rashminandasahoo @StrawberryPad
Update docs/platform/13_Templates/template.md
36c247a 
Co-authored-by: Gigi Hanna <126673019+StrawberryPad@users.noreply.github.com>
@rashminandasahoo @StrawberryPad
Update docs/platform/13_Templates/template.md
46193b0 
Co-authored-by: Gigi Hanna <126673019+StrawberryPad@users.noreply.github.com>
@rashminandasahoo @StrawberryPad
Update docs/platform/13_Templates/template.md
fd755d5 
Co-authored-by: Gigi Hanna <126673019+StrawberryPad@users.noreply.github.com>
@rashminandasahoo
Update template.md
18a5f24
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

1 similar comment
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

6 similar comments
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@rashminandasahoo rashminandasahoo merged commit 9ed2e05 into main May 4, 2023
@rashminandasahoo rashminandasahoo deleted the CDS-51341-Template-filter-tags branch May 4, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StrawberryPad StrawberryPad StrawberryPad approved these changes

@utkarshchoubey-harness utkarshchoubey-harness utkarshchoubey-harness left review comments

Assignees

@rashminandasahoo rashminandasahoo

Labels
Draft Draft/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rashminandasahoo @bot-gitexp-user @utkarshchoubey-harness @StrawberryPad