Skip to content

DOC-54404-GitOps Agent Proxy Support #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 25, 2023
Merged

DOC-54404-GitOps Agent Proxy Support #1390

merged 4 commits into from
Apr 25, 2023

Conversation

roshnisarangadharan
Copy link
Contributor

Added a section Proxy Support for GitOps Agent

Harness Developer Pull Request

Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.

What Type of PR is This?

  • Issue
  • Feature
  • Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

  • Issue(s)

House Keeping

Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

  • Tested Locally
  • Optional Screen Shoot.

@roshnisarangadharan
DOC-54404-GitOps Agent Proxy Support
3399b68 
Added a section Proxy Support for GitOps Agent
@roshnisarangadharan roshnisarangadharan added Review - SME Needs tech review from SME/dev/eng DO NOT MERGE PR is not ready to be merged. labels Apr 21, 2023
@roshnisarangadharan roshnisarangadharan self-assigned this Apr 21, 2023
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

shivagowda
shivagowda suggested changes Apr 21, 2023
View reviewed changes
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

1 similar comment
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

shivagowda
shivagowda previously approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@shivagowda shivagowda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

brian-r-fisher
brian-r-fisher previously approved these changes Apr 24, 2023
View reviewed changes
Copy link

@brian-r-fisher brian-r-fisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Left a couple minor suggestions.

@roshnisarangadharan
Apply suggestions from code review
349e575 
Co-authored-by: brian-f-harness <brian.fisher@harness.io>
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@roshnisarangadharan roshnisarangadharan merged commit 601d9aa into main Apr 25, 2023
@roshnisarangadharan roshnisarangadharan deleted the DOC-54404-GitOps-Agent-proxy-settings branch April 25, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@shivagowda shivagowda shivagowda left review comments

@brian-r-fisher brian-r-fisher brian-r-fisher left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@roshnisarangadharan roshnisarangadharan

Labels
DO NOT MERGE PR is not ready to be merged. Review - SME Needs tech review from SME/dev/eng
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roshnisarangadharan @bot-gitexp-user @shivagowda @brian-r-fisher