Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Notes CD - March, 30, version 789xx #1156

Merged
merged 13 commits into from
Mar 31, 2023
Merged

Release Notes CD - March, 30, version 789xx #1156

merged 13 commits into from
Mar 31, 2023

Conversation

roshnisarangadharan
Copy link
Contributor

Harness Developer Pull Request

Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.

What Type of PR is This?

  • Issue
  • Feature
  • Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

  • Issue(s)

House Keeping

Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

  • Tested Locally
  • Optional Screen Shoot.

@roshnisarangadharan roshnisarangadharan added documentation Review - SME Needs tech review from SME/dev/eng DO NOT MERGE PR is not ready to be merged. labels Mar 30, 2023
@roshnisarangadharan roshnisarangadharan self-assigned this Mar 30, 2023
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

michaelcretzman
michaelcretzman previously approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@michaelcretzman michaelcretzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving with suggestions.

@roshnisarangadharan @michaelcretzman
Apply suggestions from code review
1ce39ab 
Co-authored-by: Michael Cretzman <58786311+michaelcretzman@users.noreply.github.com>
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

1 similar comment
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

1 similar comment
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@roshnisarangadharan roshnisarangadharan merged commit 31920cf into main Mar 31, 2023
@roshnisarangadharan roshnisarangadharan deleted the release-notes-cd-march-20-789xx branch March 31, 2023 08:02
@roshnisarangadharan roshnisarangadharan restored the release-notes-cd-march-20-789xx branch March 31, 2023 08:03
@roshnisarangadharan roshnisarangadharan deleted the release-notes-cd-march-20-789xx branch March 31, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelcretzman michaelcretzman michaelcretzman left review comments

@SudarshanPurohit SudarshanPurohit SudarshanPurohit left review comments

@shylajas shylajas Awaiting requested review from shylajas shylajas is a code owner

@thisrohangupta thisrohangupta Awaiting requested review from thisrohangupta thisrohangupta is a code owner

Assignees

@roshnisarangadharan roshnisarangadharan

Labels
DO NOT MERGE PR is not ready to be merged. Review - SME Needs tech review from SME/dev/eng
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roshnisarangadharan @bot-gitexp-user @michaelcretzman @SudarshanPurohit