Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PL Release Notes 788xx #1078

Merged
merged 15 commits into from
Mar 24, 2023
Merged

PL Release Notes 788xx #1078

merged 15 commits into from
Mar 24, 2023

Conversation

rashminandasahoo
Copy link
Contributor

Harness Developer Pull Request

Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.

What Type of PR is This?

  • Issue
  • Feature
  • Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

  • Issue(s)

House Keeping

Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

  • Tested Locally
  • Optional Screen Shoot.

@rashminandasahoo rashminandasahoo added the DO NOT MERGE PR is not ready to be merged. label Mar 23, 2023
@rashminandasahoo rashminandasahoo self-assigned this Mar 23, 2023

### What's new

- You can now add service accounts to your resource group. (PL-31867)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can now add specific service accounts to your resource groups


- You can now add service accounts to your resource group. (PL-31867)

By doing this, you can prevent accidental or deliberate misuse of API keys by restricting who can generate them from what service accounts.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from which service accounts


### Harness Platform

- By enabling the feature flag `PL_NEW_SCIM_STANDARDS`, any CRUD operation on a user now returns user group details. (PL-31496)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now returns the details of the user groups that user is part of


A code enhancement has fixed this issue.

- SMTP configurations with special characters in the SMTP configuration name throw an `Invalid request` error. The SMTP configuration name is also used as the SMTP secret and secrets should not have any special characters. (PL-31774, ZD-40679)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little confusing - please consider revising the test.

@bot-gitexp-user
Copy link

Preview environment: https://hdh.pr.harness.io/pr-1078


The pipeline execution now fails with an exception if there is a failure in decrypting secrets.

- Despite having an active license, the CD module is not visible. (PLG-2047)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be part of the CD Release Notes? I have documented this bug already.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the logic is handled by the PL team :)


- SMTP configurations with special characters in the SMTP configuration name throw an `Invalid request` error. This happens because the SMTP configuration name is used to construct the secret name and secret names should not have any special characters. (PL-31774, ZD-40679)

This issue has been fixed by replacing special characters in SMTP configuration names with `-` before creating secret.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"..before creating a secret" or "..before creating secrets"


- User invites throw an `Invalid request` error when 2FA is enabled in the Account scope. (PL-31276)

A code enhancement has fixed this issue.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is extra space in the beginning of the line.

Copy link
Contributor

@roshnisarangadharan roshnisarangadharan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with some suggestions

Co-authored-by: roshnisarangadharan <123923215+roshnisarangadharan@users.noreply.github.com>
rashminandasahoo and others added 4 commits March 23, 2023 21:01
Co-authored-by: roshnisarangadharan <123923215+roshnisarangadharan@users.noreply.github.com>
Co-authored-by: roshnisarangadharan <123923215+roshnisarangadharan@users.noreply.github.com>
Co-authored-by: roshnisarangadharan <123923215+roshnisarangadharan@users.noreply.github.com>
@bot-gitexp-user
Copy link

Preview environment: https://hdh.pr.harness.io/pr-1078

@bot-gitexp-user
Copy link

Preview environment: https://hdh.pr.harness.io/pr-1078

@rashminandasahoo rashminandasahoo merged commit 2ab00eb into main Mar 24, 2023
@rashminandasahoo rashminandasahoo deleted the PL-releasenotes-788xx branch March 24, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE PR is not ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants