Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDS-45162-Helm subcharts #1038

Merged
merged 3 commits into from
Mar 21, 2023
Merged

Conversation

roshnisarangadharan
Copy link
Contributor

Added information about deploying helm subcharts

Harness Developer Pull Request

Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.

What Type of PR is This?

  • Issue
  • Feature
  • Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

  • Issue(s)

House Keeping

Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

  • Tested Locally
  • Optional Screen Shoot.

Added information about deploying helm subcharts
@roshnisarangadharan roshnisarangadharan self-assigned this Mar 20, 2023
@roshnisarangadharan roshnisarangadharan added Review - SME Needs tech review from SME/dev/eng DO NOT MERGE PR is not ready to be merged. labels Mar 20, 2023
@bot-gitexp-user
Copy link

Preview environment: https://hdh.pr.harness.io/pr-1038

thisrohangupta
thisrohangupta previously approved these changes Mar 20, 2023
Copy link
Collaborator

@thisrohangupta thisrohangupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now thanks Roshni

@bot-gitexp-user
Copy link

Preview environment: https://hdh.pr.harness.io/pr-1038

@roshnisarangadharan roshnisarangadharan merged commit 107dbb3 into main Mar 21, 2023
@roshnisarangadharan roshnisarangadharan deleted the CDS-45162-helm-dependencies branch March 21, 2023 07:17
@roshnisarangadharan roshnisarangadharan restored the CDS-45162-helm-dependencies branch March 21, 2023 07:17
@ravilach ravilach deleted the CDS-45162-helm-dependencies branch May 10, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE PR is not ready to be merged. Review - SME Needs tech review from SME/dev/eng
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants