Skip to content

O auth #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

O auth #14

wants to merge 14 commits into from

Conversation

dilhariedissanayake
Copy link
Collaborator

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 12, 2024
View reviewed changes
backend/routes/User/authReq.js
Comment on lines +7 to +22
router.post('/request', async (req,res,next) => {
res.header('Access-Control-Allow-Origin', 'http://localhost:3000');
res.header('Referrer-Policy', 'no-referrer-when-downgrade');

const redirectUrl='http://127.0.0.1:4000/oauth';

const oAuth2Client = new OAuth2Client(process.env.CLIENT_ID, process.env.CLIENT_SECRET,redirectUrl);

const authorizedUrl = oAuth2Client.generateAuthUrl({
access_type:'offline',
scope:'https://www.googleapis.com/auth/userinfo.profile openid',
prompt: 'consent'
});

res.json({url:authorizedUrl});
});

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
Loading
, but is not rate-limited.

Copilot Autofix

AI 11 months ago

To fix the problem, we will introduce rate limiting to the route handler using the express-rate-limit package. This will ensure that the number of requests to the /request endpoint is limited, preventing potential DoS attacks.

  1. Install the express-rate-limit package if it is not already installed.
  2. Import the express-rate-limit package in the backend/routes/User/authReq.js file.
  3. Set up a rate limiter with appropriate configuration (e.g., maximum of 100 requests per 15 minutes).
  4. Apply the rate limiter to the /request endpoint.
Suggested changeset 1
backend/routes/User/authReq.js

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/backend/routes/User/authReq.js b/backend/routes/User/authReq.js
--- a/backend/routes/User/authReq.js
+++ b/backend/routes/User/authReq.js
@@ -5,4 +5,10 @@
 const {OAuth2Client} = require('google-auth-library');
+const rateLimit = require('express-rate-limit');
 
-router.post('/request', async (req,res,next) => {
+const limiter = rateLimit({
+    windowMs: 15 * 60 * 1000, // 15 minutes
+    max: 100 // limit each IP to 100 requests per windowMs
+});
+
+router.post('/request', limiter, async (req,res,next) => {
     res.header('Access-Control-Allow-Origin', 'http://localhost:3000');
EOF
@@ -5,4 +5,10 @@
const {OAuth2Client} = require('google-auth-library');
const rateLimit = require('express-rate-limit');

router.post('/request', async (req,res,next) => {
const limiter = rateLimit({
windowMs: 15 * 60 * 1000, // 15 minutes
max: 100 // limit each IP to 100 requests per windowMs
});

router.post('/request', limiter, async (req,res,next) => {
res.header('Access-Control-Allow-Origin', 'http://localhost:3000');
Copilot is powered by AI and may make mistakes. Always verify output.
backend/routes/User/oauth.js
Comment on lines +39 to +65
router.get('/', async function (req, res) {
const code = req.query.code;
try {
const redirectUrl = 'http://127.0.0.1:4000/oauth';
const oAuth2Client = new OAuth2Client(process.env.CLIENT_ID, process.env.CLIENT_SECRET,redirectUrl);

const { tokens } = await oAuth2Client.getToken(code);
console.log('TOKENS: ',tokens);

oAuth2Client.setCredentials(tokens);

const userData = await getUserData(tokens.access_token);

let user = await User.findOne({ email: "dilhariedissanayake@gmail.com" });
if (!user) {
const newUser = await createUserFromGoogle(userData);
res.redirect(`http://localhost:3000/oauth-callback?user=${encodeURIComponent(JSON.stringify(newUser))}`);
} else {
const token = createToken(user._id);
const userWithToken = { ...user.toObject(), token };
res.redirect(`http://localhost:3000/oauth-callback?user=${encodeURIComponent(JSON.stringify(userWithToken))}`);
}
} catch(err) {
console.error("Error with signing in with Google:", err);
res.status(500).send("Error with Google authentication");
}
});

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
a database access
Loading
, but is not rate-limited.

Copilot Autofix

AI 11 months ago

To fix the problem, we will introduce rate limiting to the Express application using the express-rate-limit package. This will involve:

  1. Installing the express-rate-limit package.
  2. Setting up a rate limiter with a reasonable configuration.
  3. Applying the rate limiter to the specific route handler that performs the database access.
Suggested changeset 1
backend/routes/User/oauth.js

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/backend/routes/User/oauth.js b/backend/routes/User/oauth.js
--- a/backend/routes/User/oauth.js
+++ b/backend/routes/User/oauth.js
@@ -8,2 +8,8 @@
 const User = require("../../models/User_model");
+const rateLimit = require('express-rate-limit');
+
+const limiter = rateLimit({
+  windowMs: 15 * 60 * 1000, // 15 minutes
+  max: 100, // limit each IP to 100 requests per windowMs
+});
 
@@ -38,3 +44,3 @@
 
-  router.get('/', async function (req, res) {
+  router.get('/', limiter, async function (req, res) {
     const code = req.query.code;
EOF
@@ -8,2 +8,8 @@
const User = require("../../models/User_model");
const rateLimit = require('express-rate-limit');

const limiter = rateLimit({
windowMs: 15 * 60 * 1000, // 15 minutes
max: 100, // limit each IP to 100 requests per windowMs
});

@@ -38,3 +44,3 @@

router.get('/', async function (req, res) {
router.get('/', limiter, async function (req, res) {
const code = req.query.code;
Copilot is powered by AI and may make mistakes. Always verify output.
frontend/src/components/User_components/OAuthCallback.js
const ROLE = "user";
localStorage.setItem("role", ROLE);

localStorage.setItem('user', JSON.stringify(userData));

Check failure

Code scanning / CodeQL

Clear text storage of sensitive information High

This stores sensitive data returned by
an access to password
Loading
as clear text.

Copilot Autofix

AI 11 months ago

To fix the problem, we need to ensure that the sensitive information, specifically the password, is encrypted before being stored in localStorage. We can use the crypto module from Node.js to encrypt the password. The encrypted password will then be stored instead of the plain text password.

  1. Import the crypto module.
  2. Create an encryption function that uses a secure algorithm (e.g., aes-256-ctr) to encrypt the password.
  3. Modify the code to encrypt the password before storing the user data in localStorage.
Suggested changeset 1
frontend/src/components/User_components/OAuthCallback.js

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/frontend/src/components/User_components/OAuthCallback.js b/frontend/src/components/User_components/OAuthCallback.js
--- a/frontend/src/components/User_components/OAuthCallback.js
+++ b/frontend/src/components/User_components/OAuthCallback.js
@@ -2,2 +2,8 @@
 import { useNavigate } from 'react-router-dom';
+import crypto from 'crypto';
+
+const encrypt = (text, password) => {
+  const cipher = crypto.createCipher('aes-256-ctr', password);
+  return cipher.update(text, 'utf8', 'hex') + cipher.final('hex');
+};
 
@@ -24,3 +30,3 @@
                         gender: user.gender,
-                        password: user.password,
+                        password: encrypt(user.password, 'your-encryption-key'),
                         __v: user.__v
EOF
@@ -2,2 +2,8 @@
import { useNavigate } from 'react-router-dom';
import crypto from 'crypto';

const encrypt = (text, password) => {
const cipher = crypto.createCipher('aes-256-ctr', password);
return cipher.update(text, 'utf8', 'hex') + cipher.final('hex');
};

@@ -24,3 +30,3 @@
gender: user.gender,
password: user.password,
password: encrypt(user.password, 'your-encryption-key'),
__v: user.__v
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dilhariedissanayake