Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

Remove container_names from docker-compose.sample.yml #376

Merged
merged 1 commit into from
Jul 8, 2019

Conversation

NickBusey
Copy link
Contributor

Description

This removes the container_name lines from the sample docker-compose file.

When using the docker-compose file on a server with many other docker containers running, finding the mailserver related containers is a pain.

Fixes

Removing the container_name line changes the container names from mariadb and redis etc. to mailserver_mariadb_1 and mailserver_redis_1

This allows much easier inspection of the containers via docker ps | grep mailserver

It is also just better practice I feel like in general. Using the name mariadb locks it down for the whole server.

Type of change

  • Documentation only
  • Performance improvement
  • Refactoring (a change that neither fixes a bug nor adds a feature)
  • Test (adding missing tests or correcting existing ones)
  • Other...

Status

  • Ready

Copy link
Contributor

@sknight80 sknight80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@SaraSmiseth
Copy link

Looks Good To Me

@sknight80
Copy link
Contributor

Merging these changes.

@sknight80 sknight80 merged commit fde96ea into hardware:master Jul 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants