This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Remove container_name
s from docker-compose.sample.yml
#376
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the
container_name
lines from the sample docker-compose file.When using the docker-compose file on a server with many other docker containers running, finding the mailserver related containers is a pain.
Fixes
Removing the
container_name
line changes the container names frommariadb
andredis
etc. tomailserver_mariadb_1
andmailserver_redis_1
This allows much easier inspection of the containers via
docker ps | grep mailserver
It is also just better practice I feel like in general. Using the name
mariadb
locks it down for the whole server.Type of change
Status