Don't assume Params type #3028
Open
Don't assume Params type #3028
+61
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kblok
approved these changes
Dec 5, 2025
Member
kblok
left a comment
kblok
left a comment
There was a problem hiding this comment.
Do you want to bump the version? I can tag it if this is blocking you.
Member
|
Let's add a test expectation in |
Author
|
Not completely sure of the required syntax in Also bumped the version, since it would be nice to get a fixed version published. Thanks! |
kblok
reviewed
Dec 6, 2025
lib/PuppeteerSharp.Tests/ScreencastTests/PageScreencastTests.cs
Outdated
Show resolved
Hide resolved
lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>
Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>
kblok
reviewed
Dec 7, 2025
Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2943
Fix an assumption that
obj.Paramscan always be deserialized toConnectionResponseParams, and only make that conversion for the two messages that need it (Target.attachedToTarget,Target.detachedFromTarget).