Skip to content

Bidi: Implement mouse features #2981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 27, 2025
Merged

Bidi: Implement mouse features #2981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ac55d61
Bidi: Implement some mouse features
kblok Oct 22, 2025
6b86ecf
feature complete
kblok Oct 27, 2025
c9c5e15
update expectations
kblok Oct 27, 2025
117275e
fixes
kblok Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,3 +300,4 @@ samples/PupppeterSharpAspNetFrameworkSample/PupppeterSharpAspNetFrameworkSample/
.vscode/
tools/github-ops/.env
lib/.claude/settings.local.json
lib/.claude/settings.local.json
36 changes: 0 additions & 36 deletions lib/.claude/settings.local.json
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion lib/CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ Test directory structure demonstrates comprehensive coverage:
- Protocol-specific expectations (CDP, WebDriver BiDi)
- Headless mode variations (headless, headful, headless-shell)
- Local and upstream expectation merging

- Tests should always match the code in upstream. Tests should never be changed to match the code local code.
#### Test Server (`PuppeteerSharp.TestServer/`)
- ASP.NET Core server for hosting test pages
- wwwroot directory with test fixtures
Expand Down
105 changes: 45 additions & 60 deletions lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -765,36 +765,6 @@
"FAIL"
]
},
{
"comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
"testIdPattern": "[jshandle.spec] *getProperties*",
"platforms": [
"darwin",
"linux",
"win32"
],
"parameters": [
"webDriverBiDi"
],
"expectations": [
"FAIL"
]
},
{
"comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
"testIdPattern": "[jshandle.spec] *.getProperty*",
"platforms": [
"darwin",
"linux",
"win32"
],
"parameters": [
"webDriverBiDi"
],
"expectations": [
"FAIL"
]
},
{
"comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
"testIdPattern": "[jshandle.spec] *.evaluateHandle*",
Expand Down Expand Up @@ -885,36 +855,6 @@
"FAIL"
]
},
{
"comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
"testIdPattern": "[mocha-utils] *",
"platforms": [
"darwin",
"linux",
"win32"
],
"parameters": [
"webDriverBiDi"
],
"expectations": [
"FAIL"
]
},
{
"comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
"testIdPattern": "[mouse.spec] *",
"platforms": [
"darwin",
"linux",
"win32"
],
"parameters": [
"webDriverBiDi"
],
"expectations": [
"FAIL"
]
},
{
"comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
"testIdPattern": "[click.spec] *",
Expand Down Expand Up @@ -1664,5 +1604,50 @@
"expectations": [
"SKIP"
]
},
{
"comment": "BiDi Keyboard not implemented yet - requires BidiKeyboard implementation - NEEDS KEYBOARD",
"testIdPattern": "[mouse.spec] Mouse should select the text with mouse",
"platforms": [
"darwin",
"linux",
"win32"
],
"parameters": [
"webDriverBiDi"
],
"expectations": [
"SKIP"
]
},
{
"comment": "BiDi Keyboard not implemented yet - requires BidiKeyboard implementation - NEEDS KEYBOARD",
"testIdPattern": "[mouse.spec] Mouse should set modifier keys on click",
"platforms": [
"darwin",
"linux",
"win32"
],
"parameters": [
"webDriverBiDi"
],
"expectations": [
"SKIP"
]
},
{
"comment": "BiDi Keyboard not implemented yet - requires BidiKeyboard implementation",
"testIdPattern": "[mouse.spec] Mouse should set ctrlKey on the wheel event",
"platforms": [
"darwin",
"linux",
"win32"
],
"parameters": [
"webDriverBiDi"
],
"expectations": [
"SKIP"
]
}
]
7 changes: 0 additions & 7 deletions lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.upstream.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2134,13 +2134,6 @@
"expectations": ["SKIP"],
"comment": "Wheel event is not supported"
},
{
"testIdPattern": "[mouse.spec] Mouse should trigger hover state with removed window.Node",
"platforms": ["darwin", "linux", "win32"],
"parameters": ["cdp", "firefox"],
"expectations": ["FAIL"],
"comment": "TODO: add a comment explaining why this expectation is required (include links to issues)"
},
{
"testIdPattern": "[navigation.spec] navigation Frame.goto should navigate subframes",
"platforms": ["darwin", "linux", "win32"],
Expand Down
Loading
Loading