Skip to content

Fix chrome headless shell launcher #2969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix chrome headless shell launcher #2969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/PuppeteerSharp.Tests/TestConstants.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,9 @@ public static class TestConstants
{
SlowMo = Convert.ToInt32(Environment.GetEnvironmentVariable("SLOW_MO")),
HeadlessMode = PuppeteerTestAttribute.Headless,
Browser = IsChrome ? SupportedBrowser.Chrome : SupportedBrowser.Firefox,
Browser = IsChrome
? PuppeteerTestAttribute.Headless == HeadlessMode.Shell ? SupportedBrowser.ChromeHeadlessShell : SupportedBrowser.Chrome
: SupportedBrowser.Firefox,
EnqueueAsyncMessages = Convert.ToBoolean(Environment.GetEnvironmentVariable("ENQUEUE_ASYNC_MESSAGES") ?? "false"),
Timeout = 0,
LogProcess = true,
Expand Down
2 changes: 1 addition & 1 deletion lib/PuppeteerSharp/Launcher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public async Task<IBrowser> LaunchAsync(LaunchOptions options)

Process = options.Browser switch
{
SupportedBrowser.Chrome or SupportedBrowser.Chromium => new ChromeLauncher(executable, options),
SupportedBrowser.Chrome or SupportedBrowser.Chromium or SupportedBrowser.ChromeHeadlessShell => new ChromeLauncher(executable, options),
SupportedBrowser.Firefox => new FirefoxLauncher(executable, options),
_ => throw new ArgumentException("Invalid browser"),
};
Expand Down
8 changes: 4 additions & 4 deletions lib/PuppeteerSharp/PuppeteerSharp.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@
<Description>Headless Browser .NET API</Description>
<PackageId>PuppeteerSharp</PackageId>
<PackageReleaseNotes></PackageReleaseNotes>
<PackageVersion>20.2.4</PackageVersion>
<ReleaseVersion>20.2.4</ReleaseVersion>
<AssemblyVersion>20.2.4</AssemblyVersion>
<FileVersion>20.2.4</FileVersion>
<PackageVersion>20.2.5</PackageVersion>
<ReleaseVersion>20.2.5</ReleaseVersion>
<AssemblyVersion>20.2.5</AssemblyVersion>
<FileVersion>20.2.5</FileVersion>
<SynchReleaseVersion>false</SynchReleaseVersion>
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
<DebugType>embedded</DebugType>
Expand Down
Loading