New sampling and smoothing algorithm #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two new classes have been introduced in meas_chan.h. One represents PAC channel, another encapsulates three channels for faster sample acquisition. Meas_chan holds latest voltage measurement as well as circular buffer for current samples. Firmware may read voltage, current and power on demand, and the class applies appropriate averaging automatically. This is a commit where everything seems to work. A cleanup commit shall follow shortly.
This caused a lot of confusion while debugging.
|
Hello, Thank you for the PRs. |
|
So, any news? If you have any doubts don't hesitate to ask. |
|
It works well. Thank you for the PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is state of the art of my research on SP3, all that I could have squeezed from this hardware.
Most of the functionalities of PAC library have been removed, simplified and optimized in new class
meas_chan.This class also implements circular buffers for current measurements that can be easily replaced with other types of filters or removed - however these are set in a way that should not delay current updates in any way, so I think these changes may stay even after hardware revision.
Please refer to issue #3 for some test results.