Remove battery driver for non-android Linux #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d520a76. Normal Linux does not need the dummy battery driver; only Android does. Signed-off-by: Vittorio Gambaletta <openwrt@vittgam.net>
|
I understand the problem what you said, but disagree to revert this commit. It would be better to make it build with new kernel config, CONFIG_ODROID_DUMMY_BATTERY for instance. |
|
Okay, I will change it then! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Linux does not need the dummy battery driver; only Android does.
Also, it reports that the dummy battery has 2 °C temperature, which sets off under-temperature alarms in some userspace widgets by default.
So, remove the android dummy driver from the non-android Linux kernel.
Cheers,
Vittorio