Adding test validating image download to default location #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi hardikvasa!,
I noticed there are no tests to your project (which I like) so I decided to write some tests for it starting with this one. In this pull request I created a test to validate that the correct amount of files are downloaded to the default location.
Test logic:
5, Clean up after test finish by deleting the downloaded files.
So far I was able to write this test and meet the following guidelines:
Use only Python standard library modules.
Tests are OS agnostic due to using modules which are OS agnostic (Although I haven't had a Mac or Linux machine available to verify)
I am thinking about writing additional tests, however I would like to get some feedback from you so I could improve any future tests that I will write.
Cheers,
Amitai.