Updated Internet Connectivity Error Message to be Human-Readable #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hellogan nice little tweak. I think it would be a good idea to just abort the script as there is no point returning anything from the method call after it has failed to get the page from internet. |
|
Merged. Thanks again! 😃 |
SecorD0
pushed a commit
to SecorD0/google-images-download
that referenced
this pull request
Dec 2, 2022
Improving the error reporting if raw page could not be downloaded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Issue: #138
The error message contains suggestions to check internet connection and ssl settings because the same error is thrown if you do not have an internet connection and if you are experiencing this issue