Skip to content

use tox instead of 'setup.py test' #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 23, 2020
Merged

use tox instead of 'setup.py test' #833

merged 6 commits into from
May 23, 2020

Conversation

zariiii9003
Copy link
Collaborator

@zariiii9003 zariiii9003 marked this pull request as draft May 10, 2020 18:26
@codecov
Copy link

codecov bot commented May 10, 2020 •
edited
Loading

Codecov Report

Merging #833 into develop will increase coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #833      +/-   ##
===========================================
+ Coverage    69.93%   69.99%   +0.05%     
===========================================
  Files           70       70              
  Lines         6639     6632       -7     
===========================================
- Hits          4643     4642       -1     
+ Misses        1996     1990       -6

@zariiii9003 zariiii9003 marked this pull request as ready for review May 10, 2020 20:25
@zariiii9003
Copy link
Collaborator Author

test_thread_based_cyclic_send_task failed and i can not rerun it. All tests passed in my fork.

I guess #828 did not fix it.

hardbyte
hardbyte approved these changes May 19, 2020
View reviewed changes
Copy link
Owner

@hardbyte hardbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff

setup.py
@@ -29,30 +28,9 @@
extras_require = {
"seeedstudio": ["pyserial>=3.0"],
"serial": ["pyserial~=3.0"],
"neovi": ["python-ics>=2.12", "filelock"],
"neovi": ["python-ics>=2.12"],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this change be here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily, but i noticed that filelock is mentioned in install_requires already.

@hardbyte hardbyte merged commit 80f6952 into hardbyte:develop May 23, 2020
@zariiii9003 zariiii9003 deleted the use_tox branch May 24, 2020 12:48
@pierreluctg pierreluctg mentioned this pull request Aug 27, 2020
Merged
@zariiii9003 zariiii9003 mentioned this pull request Oct 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardbyte hardbyte hardbyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zariiii9003 @hardbyte