Clean up socketcan #766
Merged
Clean up socketcan #766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #766 +/- ##
===========================================
+ Coverage 69.75% 70.12% +0.37%
===========================================
Files 70 70
Lines 6599 6681 +82
===========================================
+ Hits 4603 4685 +82
Misses 1996 1996 |
karlding
reviewed
May 2, 2020
karlding
reviewed
May 2, 2020
karlding
reviewed
May 2, 2020
karlding
reviewed
May 2, 2020
Co-authored-by: karl ding <karlding@users.noreply.github.com>
karlding
approved these changes
May 6, 2020
hardbyte
approved these changes
May 12, 2020
|
👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only small stuff: Adds documentation, simplifications and better error handling.
Should we keep the change to the coverage config? It allows the coverage artifacts to be viewed/downloaded here.