"Add support for the mf4 io format" (Adapted version of #554) #697
Conversation
| @@ -0,0 +1,392 @@ | |||
| """ | |||
There was a problem hiding this comment.
Should this class also be added to the lookup dictionaries in the logger.py and player.py files?
|
|
||
| def __init__(self, file): | ||
| """ | ||
| :param file: a path-like object or as file-like object to read from |
There was a problem hiding this comment.
s/as file-like object/a file-like object
* fix documentation * fix item access on FD_DLC2LEN dict * add compression argument to MF4Writer stop method
|
Hey @danielhrisca thanks for taking care of this, but where exactly did you push the changes so that I can pull them into this repo? |
|
I've pushed the commits to my branch https://github.com/danielhrisca/python-can/tree/mf4_io |
|
Okay, I rebased this branch on your work. It was quite strange, but I hope everything went right. Please base you next modifications on this branch directly. ;) One issue remains though: It might need some fix. |
|
c311af4 should fix that |
|
Okay, I guess this can be merged now. (@karlding / @danielhrisca ?) |
|
Can you check your rebase @felixdivo please? I see various diffs in @danielhrisca's branch which don't seem to be reflected here. |
|
Uff, I hate history rewriting. I might give it another try, will see when I have time. |
| :param database: optional path to a DBC or ARXML file that contains | ||
| message description. | ||
| """ | ||
| super().__init__(file, mode="r+b") |
There was a problem hiding this comment.
Description says to open in write binary, but code uses read binary mode.
|
Sorry, I currently do not have the time to complete this or work much on this project. |
|
Is this anytime soon getting merged? |
|
I don't really know what went wrong here. However, the branch and all discussions are still there. Anyone is free to provide a clean PR. I will probably not do it. |
|
For anyone tracing along in the future, the next iteration is #1289 |
See #554 for the changes. This PR was created such that some changes could be applied before merging into the develop.
There is still an issue on PyPy (#696), but it's okay to merge for now since it runs nicely on CPython.
Closes #506.