-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typing annotations for functions in can.bus #652
Conversation
I wasn't sure how to handle annotating Adding annotations to
As such, I've skipped it for now, but any ideas or insights would be appreciated! |
This adds typing annotations for use via mypy for all functions under can.bus. This works towards PEP 561 compatibility.
38e18df
to
e03464b
Compare
Codecov Report
@@ Coverage Diff @@
## develop #652 +/- ##
==========================================
+ Coverage 67.67% 67.7% +0.03%
==========================================
Files 68 68
Lines 6098 6104 +6
==========================================
+ Hits 4127 4133 +6
Misses 1971 1971 |
Codecov Report
@@ Coverage Diff @@
## develop #652 +/- ##
===========================================
+ Coverage 67.67% 67.73% +0.05%
===========================================
Files 68 69 +1
Lines 6098 6109 +11
===========================================
+ Hits 4127 4138 +11
Misses 1971 1971 |
Add a Type Alias for CAN Filters used by can.bus
4a6efd2
to
f167be6
Compare
Remove unused Dict from can.bus imports
With the introduction of the sphinx-autodoc-typehints extension, we don't need to duplicate typing information in the docstring as well as the function signature.
This adds typing annotations for use via mypy for all functions under
can.bus.
This works towards PEP 561 compatibility.