Skip to content

[canalyst] get CANalyst-II working through init, once more #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 12, 2019

Conversation

dankamongmen
Copy link
Contributor

  • Switch 'baud' to 'bitrate' from canalystii.py
  • Pass kwargs through to BusABC's initializer

With these two changes, I was able to get can-logger to start on either one of my CANalyzer-II without a ~/.canrc. Without them, I just saw a bunch of errors.

[schwarzgerat](0) $ cat ~/.canrc 
[default]
interface=canalystii
[schwarzgerat](0) $ python3 -m can.logger -i canalystii -c 1 -b 125000
success: device 04D8:0053 opened
success: set configuration #1
success: claim_interface #0
Connected to CANalystIIBus: CANalyst-II: device 0, channels [1]
Can Logger (Started on 2019-06-08 11:36:42.903185)
unknown file type "None", falling pack to can.Printer
[schwarzgerat](0)

Prior to this change, I'd get stuff like:

TypeError: __init__() got an unexpected keyword argument 'single_handle'

Failed tests hold steady at 2.

@codecov
Copy link

codecov bot commented Jun 8, 2019

Codecov Report

Merging #617 into develop will not change coverage.
The diff coverage is 0%.

@@          Coverage Diff           @@
##           develop   #617   +/-   ##
======================================
  Coverage       64%    64%           
======================================
  Files           63     63           
  Lines         5607   5607           
======================================
  Hits          3589   3589           
  Misses        2018   2018

@christiansandberg christiansandberg merged commit e717da7 into hardbyte:develop Jun 12, 2019
@karlding karlding mentioned this pull request Nov 13, 2019
hardbyte pushed a commit that referenced this pull request Dec 28, 2019
Pass kwargs through to BusABC's initializer.

Doesn't backport changing baud to bitrate to avoid changing the API
hardbyte added a commit that referenced this pull request Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants