Skip to content

Remove unused SocketCAN constants #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 12, 2019

Conversation

karlding
Copy link
Collaborator

These constants are no longer used in the code and can be cleaned up.

Fixes #574

karlding added 2 commits May 11, 2019 15:45
These constants are no longer used in the code and can be cleaned up

Fixes hardbyte#574
@codecov
Copy link

codecov bot commented May 11, 2019

Codecov Report

Merging #575 into develop will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #575      +/-   ##
===========================================
- Coverage    64.11%   64.07%   -0.04%     
===========================================
  Files           63       63              
  Lines         5718     5712       -6     
===========================================
- Hits          3666     3660       -6     
  Misses        2052     2052

@codecov
Copy link

codecov bot commented May 11, 2019

Codecov Report

Merging #575 into develop will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           develop   #575      +/-   ##
=========================================
- Coverage    64.11%    64%   -0.12%     
=========================================
  Files           63     63              
  Lines         5718   5700      -18     
=========================================
- Hits          3666   3648      -18     
  Misses        2052   2052

@hardbyte hardbyte merged commit 8c63278 into hardbyte:develop May 12, 2019
@hardbyte hardbyte added this to the 3.2 Release milestone May 12, 2019
@karlding karlding deleted the remove_unused_socketcan_constants branch May 12, 2019 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potentially unused SocketCAN constants?
2 participants