Skip to content

Turn BusState into an enum #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 19, 2019
Merged

Turn BusState into an enum #533

merged 9 commits into from
Apr 19, 2019

Conversation

felixdivo
Copy link
Collaborator

Requires the aenum library on Python < 3.6. The enum34 library was not used since it does not provide auto-assigned values.

Contains some small fixes/improvements to related code parts.

Closes #519.

@hardbyte you may add your other changes to this PR as well

@felixdivo felixdivo added the api label Mar 13, 2019
@felixdivo felixdivo added this to the 3.2 Release milestone Mar 13, 2019
@felixdivo felixdivo self-assigned this Mar 13, 2019
@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #533 into develop will increase coverage by 0.02%.
The diff coverage is 64.28%.

@@             Coverage Diff             @@
##           develop     #533      +/-   ##
===========================================
+ Coverage    64.44%   64.47%   +0.02%     
===========================================
  Files           63       63              
  Lines         5651     5655       +4     
===========================================
+ Hits          3642     3646       +4     
  Misses        2009     2009

@felixdivo felixdivo requested a review from hardbyte March 15, 2019 08:20
@felixdivo
Copy link
Collaborator Author

@hardbyte this now works

@hardbyte hardbyte merged commit dcf87ce into develop Apr 19, 2019
@hardbyte hardbyte deleted the add-enums branch April 19, 2019 08:23
@hardbyte hardbyte mentioned this pull request Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shouldn't BusState be an enum?
2 participants