-
Notifications
You must be signed in to change notification settings - Fork 638
Message class changes #497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #497 +/- ##
===========================================
+ Coverage 63.81% 64.54% +0.73%
===========================================
Files 63 63
Lines 5626 5646 +20
===========================================
+ Hits 3590 3644 +54
+ Misses 2036 2002 -34 |
@hardbyte @christiansandberg Could one of you review this change? |
hardbyte
approved these changes
Feb 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a deprecation warning to
can.Message.extended_id
as discussed in #424.Further, this PR
can.Message
will be removedlen(some_message)
to return the DLC instead onlen(self.data)
, so the method also works on remote framescan.Message(..., check=True)
to actually raise aValueError
and not anAssertionError
on invalid parameters, as was documented previously; and also make it run when assertions are disabledcan.Message
, like Unicode errors being avoidedhypothesis
test forcan.Message
test/*