-
Notifications
You must be signed in to change notification settings - Fork 638
Feature: API for automatic configuration detection #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
088423d
factored out some common import functionality
felixdivo 828b10f
cleaning up interface.py
felixdivo 405d569
make class Bus in interface.py extend BusABC (IDEs can now see the at…
felixdivo c60b065
added static BusABC._detect_available_configs()
felixdivo f093fca
added public detect_available_channels() method
felixdivo 005a26d
added _detect_available_configs() to virtual bus and added locks arou…
felixdivo 91a50a0
fixes for channel detection
felixdivo 3ebdfec
various fixes for channel detection
felixdivo c9c4b30
added unit tests for detect_available_configs()
felixdivo 17dd758
small fixes for Python 2/3 compatibility
felixdivo b66a8d4
added channel detection for socketcan
felixdivo 861656b
Merge branch 'develop' into feature-channel-detection
felixdivo 34e3c52
added tests for socketcan channel detection
felixdivo f0c927f
catch ImportErrors in detect_available_configs()
felixdivo f3b7cfc
fix loading of socketcan's special case
felixdivo c31770e
various smaller fixes
felixdivo f0f8ae8
added link to helper method in socketcan bus classes
felixdivo 3f51084
added some tests and fixed calls to helper
felixdivo de38513
windows fix
felixdivo bdf6a30
skip socketcan test on windwos
felixdivo 81c8722
Win + Python 2 fix
felixdivo 69404ba
use different command call in socketcan's find_available_interfaces()
felixdivo 886bc9f
debugging commit
felixdivo e8c4407
debugging commit
felixdivo 6732fbb
corrected index in command parsing
felixdivo 00f73ae
cleanups
felixdivo 5bf6f03
renamed "search_only_in" to "interfaces"
felixdivo e0212ea
fix method signature in unit test
felixdivo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you consider passing a timeout value or
abort
event?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, not really, since that would be comparably difficult to implement and is not necessary for the two interfaces I implemented it for. (
socketcan
&virtual
) Do you really think we need it?