Skip to content

Conversation

@umlaeute
Copy link
Contributor

  • PCAN_BITRATES are stored in BIGendian, no use to byteswap on littleendian.
  • Also the TPCANChannelInformation expects data in the native byte order

Closes: #1624

PCAN_BITRATES are stored in BIGendian, no use to byteswap on littleendian.
Also the TPCANChannelInformation expects data in the native byte order

Closes: hardbyte#1624
@umlaeute umlaeute force-pushed the bugfix/bigendian-tests branch from 9ead196 to 4d1794f Compare June 29, 2023 10:39
Copy link
Collaborator

@zariiii9003 zariiii9003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@zariiii9003 zariiii9003 merged commit c5d7a7c into hardbyte:develop Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tests fail on bigendian

2 participants