Skip to content

Remove script files #1604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2023
Merged

Remove script files #1604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/scripts.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Scripts

The following modules are callable from ``python-can``.

They can be called for example by ``python -m can.logger`` or ``can_logger.py`` (if installed using pip).
They can be called for example by ``python -m can.logger`` or ``can_logger`` (if installed using pip).

can.logger
----------
Expand Down
8 changes: 4 additions & 4 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,10 @@ classifiers = [
]

[project.scripts]
"can_logconvert.py" = "scripts.can_logconvert:main"
"can_logger.py" = "scripts.can_logger:main"
"can_player.py" = "scripts.can_player:main"
"can_viewer.py" = "scripts.can_viewer:main"
can_logconvert = "can.logconvert:main"
can_logger = "can.logger:main"
can_player = "can.player:main"
can_viewer = "can.viewer:main"

[project.urls]
homepage = "https://github.com/hardbyte/python-can"
Expand Down
11 changes: 0 additions & 11 deletions scripts/can_logconvert.py
View file
Open in desktop

This file was deleted.

11 changes: 0 additions & 11 deletions scripts/can_logger.py
View file
Open in desktop

This file was deleted.

11 changes: 0 additions & 11 deletions scripts/can_player.py
View file
Open in desktop

This file was deleted.

11 changes: 0 additions & 11 deletions scripts/can_viewer.py
View file
Open in desktop

This file was deleted.

12 changes: 3 additions & 9 deletions test/test_scripts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,8 @@ class TestLoggerScript(CanScriptTest):
def _commands(self):
commands = [
"python -m can.logger --help",
"python scripts/can_logger.py --help",
"can_logger --help",
]
if IS_UNIX:
commands += ["can_logger.py --help"]
return commands

def _import(self):
Expand All @@ -90,10 +88,8 @@ class TestPlayerScript(CanScriptTest):
def _commands(self):
commands = [
"python -m can.player --help",
"python scripts/can_player.py --help",
"can_player --help",
]
if IS_UNIX:
commands += ["can_player.py --help"]
return commands

def _import(self):
Expand All @@ -106,10 +102,8 @@ class TestLogconvertScript(CanScriptTest):
def _commands(self):
commands = [
"python -m can.logconvert --help",
"python scripts/can_logconvert.py --help",
"can_logconvert --help",
]
if IS_UNIX:
commands += ["can_logconvert.py --help"]
return commands

def _import(self):
Expand Down