Skip to content

Add gzip check to compress method #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 13, 2022
Merged

Add gzip check to compress method #1429

merged 3 commits into from
Nov 13, 2022

Conversation

@j-c-cook
Copy link
Contributor

@j-c-cook j-c-cook commented Nov 12, 2022 •
edited
Loading

Seeks to address @zariiii9003's request from #1385 (comment).

closes #1378

@j-c-cook j-c-cook mentioned this pull request Nov 12, 2022
Closed
@codecov
Copy link

codecov bot commented Nov 12, 2022 •
edited
Loading

Codecov Report

Merging #1429 (93677ea) into develop (5f485db) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1429      +/-   ##
===========================================
- Coverage    65.28%   65.28%   -0.01%     
===========================================
  Files           81       81              
  Lines         8830     8832       +2     
===========================================
+ Hits          5765     5766       +1     
- Misses        3065     3066       +1

@j-c-cook j-c-cook mentioned this pull request Nov 12, 2022
Merged
@felixdivo felixdivo added this to the 4.1.0 Release milestone Nov 13, 2022
@felixdivo felixdivo added bug file-io about reading & writing to files labels Nov 13, 2022
zariiii9003
zariiii9003 reviewed Nov 13, 2022
View reviewed changes
j-c-cook and others added 2 commits November 13, 2022 12:15
@j-c-cook @zariiii9003
Update can/io/logger.py
3dc6028 
Co-authored-by: zariiii9003 <52598363+zariiii9003@users.noreply.github.com>
@j-c-cook
Update logger.py
93677ea
zariiii9003
zariiii9003 approved these changes Nov 13, 2022
View reviewed changes
Copy link
Collaborator

@zariiii9003 zariiii9003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@zariiii9003 zariiii9003 merged commit f739bcc into hardbyte:develop Nov 13, 2022
@j-c-cook j-c-cook deleted the issue1378_gziperror2 branch November 13, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zariiii9003 zariiii9003 zariiii9003 approved these changes

Assignees

@j-c-cook j-c-cook

Labels

bug file-io about reading & writing to files

Projects

None yet

Milestone

4.1.0 Release

Development

Successfully merging this pull request may close these issues.

GzipFile BLFWriter negative seek error

3 participants

@j-c-cook @zariiii9003 @felixdivo