Skip to content

Pass file mode to compress function #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Pass file mode to compress function #1384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions can/io/logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def __new__( # type: ignore

file_or_filename: AcceptedIOType = filename
if suffix == ".gz":
suffix, file_or_filename = Logger.compress(filename)
suffix, file_or_filename = Logger.compress(filename, *args, **kwargs)

try:
return Logger.message_writers[suffix](file_or_filename, *args, **kwargs)
Expand All @@ -98,13 +98,18 @@ def __new__( # type: ignore
) from None

@staticmethod
def compress(filename: StringPathLike) -> Tuple[str, FileLike]:
def compress(
filename: StringPathLike, *args: Any, **kwargs: Any
) -> Tuple[str, FileLike]:
"""
Return the suffix and io object of the decompressed file.
File will automatically recompress upon close.
"""
real_suffix = pathlib.Path(filename).suffixes[-2].lower()
mode = "ab" if real_suffix == ".blf" else "at"
if kwargs.get("append", False):
mode = "ab" if real_suffix == ".blf" else "at"
else:
mode = "wb" if real_suffix == ".blf" else "wt"

return real_suffix, gzip.open(filename, mode)

Expand Down