Fix _default_name for compressed files #1383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zariiii9003 This is ready for review. |
Codecov Report
@@ Coverage Diff @@
## develop #1383 +/- ##
===========================================
+ Coverage 66.21% 66.25% +0.04%
===========================================
Files 86 86
Lines 9021 9021
===========================================
+ Hits 5973 5977 +4
+ Misses 3048 3044 -4 |
|
Thank you |
j-c-cook
added a commit
to j-c-cook/python-can
that referenced
this pull request
Nov 11, 2022
This reverts commit 9d9cb16.
j-c-cook
added a commit
to j-c-cook/python-can
that referenced
this pull request
Dec 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the compressed
SizedRotatingLoggercreated files such as:file.log_2022-08-27T111103_#000.gzGiven the changes in 115f3de, zipped file names are supported:
file_2022-08-27T112545_#000.log.gzcloses #1382