Skip to content

Conversation

@zariiii9003
Copy link
Collaborator

Close #1359

@zariiii9003 zariiii9003 added the file-io about reading & writing to files label Aug 8, 2022
@zariiii9003 zariiii9003 added this to the 4.1.0 milestone Aug 8, 2022
@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #1367 (84d691c) into develop (73663b6) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@           Coverage Diff            @@
##           develop    #1367   +/-   ##
========================================
  Coverage    66.13%   66.13%           
========================================
  Files           86       86           
  Lines         8998     9004    +6     
========================================
+ Hits          5951     5955    +4     
- Misses        3047     3049    +2     

@zariiii9003 zariiii9003 added the api label Aug 8, 2022
@j-c-cook
Copy link
Contributor

j-c-cook commented Aug 8, 2022

It appears that you plan to close #1359 with this PR. Do you plan to merge this and close #1360 without a merge? If so, there are changes in #1360 that are not included here, but should be to properly close #1359. I have created a pull request into your branch: zariiii9003#5. These additions will currently accomplish the following two items:

One additional item that I have not yet had time to address is based on @hardbyte's comment:

@zariiii9003
Copy link
Collaborator Author

I merged your changes. Once #1366 is merged, you can pass any parameters from the CLI to the logger instantiation.

@zariiii9003 zariiii9003 merged commit c1736cc into hardbyte:develop Aug 10, 2022
@zariiii9003 zariiii9003 deleted the file_size branch August 10, 2022 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api file-io about reading & writing to files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sized Rotating Logger bug for BLFWriter file_size (-s) argument

2 participants