Skip to content

Conversation

@zariiii9003
Copy link
Collaborator

No description provided.

@zariiii9003 zariiii9003 added this to the 4.1.0 milestone Aug 7, 2022
@codecov
Copy link

codecov bot commented Aug 7, 2022

Codecov Report

Merging #1363 (48ead6e) into develop (cd51ec4) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1363      +/-   ##
===========================================
- Coverage    65.26%   65.24%   -0.03%     
===========================================
  Files           81       81              
  Lines         8827     8832       +5     
===========================================
+ Hits          5761     5762       +1     
- Misses        3066     3070       +4     

@hardbyte hardbyte changed the title Update CHANGELOG.md Update CHANGELOG for v4.1.0 release Nov 10, 2022
@felixdivo
Copy link
Collaborator

felixdivo commented Nov 12, 2022

As stated here, there will be no 4.0.1 release, but instead this immediate one (4.1.0). All issues & PRs from milestone 4.0.1 will be assigned to milestone 4.1.0.

EDIT: Done.

@felixdivo
Copy link
Collaborator

@zariiii9003 I guess you also went over the PRs/issues that are not tagged with the milestone? Not all (actually just a few) merged PRs were assigned to any. If you did that, this PR has my approval. 👍 Thanks for collecting the changes!

@zariiii9003
Copy link
Collaborator Author

I did not look at the github labels. I just scrolled through the commit history to find any changes, that might be relevant to users.

@felixdivo
Copy link
Collaborator

Is this codecov problem known/being worked on? (@hardbyte)

@zariiii9003
Copy link
Collaborator Author

zariiii9003 commented Nov 13, 2022

Codecov is just super unreliable. We can change the CI config so it ignores codecov failures. Or switch to coveralls entirely.

@felixdivo
Copy link
Collaborator

Sound's good. I don't have strong feelings here as long as it works. 🤷

@zariiii9003 zariiii9003 marked this pull request as ready for review November 13, 2022 18:55
@zariiii9003
Copy link
Collaborator Author

@hardbyte Feel free to merge and release.

@hardbyte hardbyte merged commit 8c4ed5f into hardbyte:develop Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants