-
Notifications
You must be signed in to change notification settings - Fork 639
WIP: Add method to calculate load on a bus #1105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You should take a look into At least when you are working on Linux (Debian/Ubuntu) |
Codecov Report
@@ Coverage Diff @@
## develop #1105 +/- ##
===========================================
- Coverage 66.03% 65.94% -0.09%
===========================================
Files 86 86
Lines 8917 8932 +15
===========================================
+ Hits 5888 5890 +2
- Misses 3029 3042 +13 |
Thank you for the suggestion. It seems the method I implemented is somewhat different since it's intended to be used as a method of an object such as ThreadSafeBus, rather than continuously polling multiple channels. I have tested my code but have not hardcoded test cases. |
Going to give this some more attention- I'd like to add additional functionality so that a thread is spawned to track CAN traffic in the background. |
No longer need this feature. |
Hi @wbarnha, Thx |
Long story short, this was written when I was not aware of all tools in Plus there's definitely more efficient ways of calculating this rather than my slow implementation. |
PR created to address Issue #972. WIP since I'm not done testing this.
I also preemptively opened a PR because I'm having some difficulty determining what the bitrate of a particular CAN interface is configured to be. If anyone could point me in the right direction, I'd be grateful. I saw that some custom interfaces have bitrates hard-coded in their respective constants.py files.