Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ES2017 support, drop node 8 #2740

Merged
merged 6 commits into from
Nov 22, 2019
Merged

add ES2017 support, drop node 8 #2740

merged 6 commits into from
Nov 22, 2019

Conversation

msimerson
Copy link
Member

@msimerson msimerson commented Nov 22, 2019

Changes proposed in this pull request:

  • node 8 maintenance ends soon, drop it from testing
  • add eslint ecmaVersion: 8 (2017), to add async/await support
  • ignore a couple frequent DNS failures in tests (on GitHub Actions & AppVeyor)

Checklist:

  • docs updated
  • tests updated
  • Changes updated

shows up in Win test where initial err aborts processing of tls dir contents
- add eslint ecmaVersion: 8, to add async/await support
maybe save myself some time looking it up next time
@msimerson msimerson merged commit 3e779b0 into haraka:master Nov 22, 2019
@msimerson msimerson deleted the es2017 branch November 22, 2019 23:07
@celesteking
Copy link
Contributor

Why not start dropping semicolons?

@celesteking
Copy link
Contributor

ECMAScript since its earliest days supported automatic semicolon inference/insertion, of course. But people coding ECMAScript 5 started it in an era where lots of tools (especially source code compressors) had problems when semicolons where left out from the source code. As a consequence, most ECMAScript 5 coders maintained the traditional coding style with semicolons as the syntactic sugar, although in most of the cases they are not necessary. But this era is gone today. Both ECMAScript 6 and all tools (including compressors) perfectly support automatic semicolon inference/insertion nowadays. As a consequence, ECMAScript 6 coders nowadays can get rid of nearly all semicolons and remove clutter from their source code. Ralf S. Engelschall is a strong promoter of reducing source code to its bare minimum. Hence, in his personal opinion ECMAScript 6 should be coded with as less syntactic sugar as possible and hence without semicolons.

@msimerson
Copy link
Member Author

I'm not opposed. In new JS projects, I use them only when necessary.

@celesteking
Copy link
Contributor

I propose the following:

  • Not using semicolons in any new code
  • Removing semicolons in old code that's being modified, changed or just lying nearby (e.g., inside the same function)

All this to remove the necessity of going through entire codebase and making a huge semicolons-only change commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants