Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add partial ownership transfer to UC DAO module #340

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Yurist-85
Copy link
Contributor

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 63.38583% with 93 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
x/ucdao/types/msg.go 43.66% 35 Missing and 5 partials ⚠️
x/ucdao/keeper/keeper.go 58.06% 9 Missing and 4 partials ⚠️
x/ucdao/keeper/grpc_query.go 69.69% 6 Missing and 4 partials ⚠️
x/ucdao/keeper/msg_server.go 83.33% 4 Missing and 5 partials ⚠️
x/ucdao/keeper/account_balances.go 79.48% 6 Missing and 2 partials ⚠️
x/ucdao/keeper/genesis.go 0.00% 7 Missing ⚠️
x/ucdao/types/keys.go 50.00% 4 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants