Skip to content

Commit

Permalink
TEST/MINOR: fix teardown removing tcp configmap not called for Endpoi…
Browse files Browse the repository at this point in the history
…ntsSuite

test.Delete(config/tcp.yaml) teardown was not called.
Then the configmap stayed after the test suite executed.
This MR fixes this to crrectly cleanup the tcp configmap after the test executes.
  • Loading branch information
hdurand0710 committed May 6, 2024
1 parent 61d9224 commit e4cf957
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion deploy/tests/e2e/endpoints/suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ func (suite *EndpointsSuite) BeforeTest(suiteName, testName string) {
suite.tmplData.Replicas = 4
suite.NoError(test.Apply("config/endpoints.yaml.tmpl", test.GetNS(), suite.tmplData))
suite.NoError(test.Apply("config/tcp.yaml", "", nil))
test.AddTearDown(func() error {
suite.test.AddTearDown(func() error {
return suite.test.Delete("config/tcp.yaml")
})
suite.Require().Eventually(func() bool {
Expand Down

0 comments on commit e4cf957

Please sign in to comment.