-
Notifications
You must be signed in to change notification settings - Fork 201
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
BUG/MINOR: Fix IngressClass filtering
The controller should follow the followig rules in order to accept or not an Ingress Resource: - If the "--ingress.class" argument of the controller is not configured: - Accept Ingress resource when neither "ingress.class" annotation nor "ingressClassName" fields are set. - Accept Ingress resource when "ingress.class" annotation is not set but "ingressClassName" field matches. - If the "--ingress.class" argument of the controller is configured: - Accept Ingress resource when neither "ingress.class" annotation nor "ingressClassName" fields are set but controller argument "--EmptyIngressClass" is enabled. - Accept Ingress resource when "--ingress.class" argument is equal to "ingress.class" annotation. - Accept Ingress resource when "ingressClassName" field matches. - Ignore Ingress resource otherwise. - "ingressClassName" field (of Ingress resource) matches means that the corresponding IngressClass resource should have the Spec.Controller field equal to "haproxy.org/ingress-controller/<ingress.class>" where <ingress.class> is the value of the "--ingress.class" argument of the controller. In addition to rewriting Ingress eligibility to make it clearer this commit fixes "ingressClassName" field matching as discussed in github issure #354
- Loading branch information
Showing
5 changed files
with
46 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters