MEDIUM: runtime: add all fields for runtime server.#133
Open
AdamJCrawford wants to merge 2 commits intohaproxytech:masterfrom
Open
MEDIUM: runtime: add all fields for runtime server.#133AdamJCrawford wants to merge 2 commits intohaproxytech:masterfrom
AdamJCrawford wants to merge 2 commits intohaproxytech:masterfrom
Conversation
Collaborator
|
This looks fine, it just seems you changed the swagger version, downgraded it so it's generating different models. Can you use the upstream one and run make models again? |
Contributor
Author
Yeah, wasn't sure what to do about the version. I was just following the readme |
AdamJCrawford
force-pushed
the
Add-values-to-runtime-server
branch
from
59fe20a to
5a7d665
Compare
Contributor
Author
@mjuraga regenerated the models. Let me know if you would like me to make any other changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #131