Skip to content

smrt-svelte: Tenants components audit findings #911

@willgriffin

Description

@willgriffin

Overview

Audit of Tenants components (TenantCard, TenantSwitcher) found export and theming issues.

Critical Issues

1. Missing index.ts Barrel File

  • Problem: No barrel file for clean imports
  • Fix: Create tenants/index.ts

2. TenantCard - Wrong Icon Name

  • Problem: Uses name="menu" for edit button
  • Fix: Use proper edit icon

3. TenantSwitcher - Inconsistent Styling

  • Problem: Uses hex colors instead of Material 3 tokens
  • Fix: Use --md-sys-color-*

Warning Issues

4. No ARIA Label on TenantSwitcher Select

  • Missing accessible label for dropdown

5. No Keyboard Alternative for Voice

  • TenantCard edit actions keyboard accessible but could be improved

6. No Loading State

  • No skeleton when tenant data loading

Enhancement Suggestions

  1. Add avatar image support to TenantCard
  2. Add tenant status indicators
  3. Add search/filter for TenantSwitcher with many tenants
  4. Add recent tenants section
  5. Export Tenant and Membership types

Acceptance Criteria

  • Barrel file created
  • Edit icon fixed
  • CSS variables standardized
  • ARIA labels added

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions