Switch from yarn to pnpm #45
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates the project from yarn to pnpm as the package manager, aligning with the standardization effort across all Happo repositories. The migration is motivated by pnpm's improved ease of use and performance.
Key Changes:
- Removed yarn.lock and added pnpm-lock.yaml for dependency resolution
- Updated CircleCI configuration to install and use pnpm via corepack
- Changed CI commands from
yarn install/yarn testtopnpm install/pnpm test
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| yarn.lock | Removed entire yarn lockfile (2334 lines) as it's replaced by pnpm-lock.yaml |
| .circleci/config.yml | Added pnpm installation via corepack and updated commands to use pnpm instead of yarn |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.circleci/config.yml
Outdated
| command: | | ||
| npm install --global corepack@latest | ||
| corepack enable | ||
| corepack prepare pnpm@latest-10 --activate |
There was a problem hiding this comment.
The version specifier pnpm@latest-10 appears to be invalid. According to pnpm documentation, valid version specifiers include:
- Specific versions:
pnpm@9.0.0 - Version ranges:
pnpm@9orpnpm@^9.0.0 - Latest:
pnpm@latest
The syntax latest-10 is not a recognized pnpm version format. This should be changed to either:
pnpm@10(for latest v10.x)pnpm@latest(for the absolute latest version)- A specific version like
pnpm@10.0.0
This will likely cause the CI build to fail with a version resolution error.
| corepack prepare pnpm@latest-10 --activate | |
| corepack prepare pnpm@10 --activate |
We've started using pnpm throughout all Happo repos, and we find that it's easier to use and faster.
| corepack prepare pnpm@latest --activate | ||
| - run: | ||
| name: Install Dependencies | ||
| command: pnpm install |
There was a problem hiding this comment.
I think we should do this like we do in our other repos. Here's an example of the aliases we use:
We've started using pnpm throughout all Happo repos, and we find that it's easier to use and faster.