failAction loses stacktrace context

Returning promise without await causes Node.js to lose stacktrace context making hapijs app harder to debug
hapijs · Jan 29, 2024 · a27f7e0 · a27f7e0
1 parent 7c67d19
commit a27f7e0
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/toolkit.js b/lib/toolkit.js
@@ -114,7 +114,7 @@ exports.Manager = class {
         this._toolkit.prototype[name] = method;
     }
 
-    failAction(request, failAction, err, options) {
+    async failAction(request, failAction, err, options) {
 
         const retain = options.retain ? err : undefined;
         if (failAction === 'ignore') {
@@ -130,7 +130,7 @@ exports.Manager = class {
             throw err;
         }
 
-        return this.execute(failAction, request, { realm: request.route.realm, args: [options.details ?? err] });
+        return await this.execute(failAction, request, { realm: request.route.realm, args: [options.details ?? err] });
     }
 };