Invalidates rejection with wrong type or message arguments#121
Merged
cjihrig merged 2 commits intohapijs:masterfrom Jan 2, 2018
Merged
Invalidates rejection with wrong type or message arguments#121cjihrig merged 2 commits intohapijs:masterfrom
cjihrig merged 2 commits intohapijs:masterfrom
Conversation
Contributor
|
This is a step in the right direction. I think the type checking and argument parsing in general still has a way to go. For example: await Code.expect(Promise.reject(new Error('kaboom'))).to.reject(NaN);
|
Contributor
Author
|
@cjihrig I just tackled the problem that I noticed/was having, which was the |
Contributor
Author
|
@cjihrig, just pushed a new commit to check the type argument as well. |
Contributor
Author
|
@cjihrig do you think the current checks and tests are sufficient? |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #119