Skip to content

Changed the discord providers image url prefix #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 19, 2017
Merged

Changed the discord providers image url prefix #325

merged 3 commits into from
Nov 19, 2017

Conversation

Niputi
Copy link
Contributor

@Niputi Niputi commented Oct 23, 2017

According to the discord api the image prefix should be https://cdn.discordapp.com/

@ldesplat ldesplat added this to the 8.9.0 milestone Nov 19, 2017
@ldesplat ldesplat added the feature New functionality or improvement label Nov 19, 2017
@ldesplat
Copy link
Contributor

ldesplat commented Nov 19, 2017

I am merging this but will change the image format. https://caniuse.com/#feat=webp clearly show webp as not being an appropriate default format. Will change to png to match the discord's documentation.
Thank you.

@ldesplat ldesplat merged commit 215610f into hapijs:master Nov 19, 2017
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New functionality or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants